Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX support either NO_COLOR or FORCE_COLOR=0 to turn off color #3272

Merged
merged 3 commits into from Dec 7, 2019

Conversation

kikonen
Copy link
Contributor

@kikonen kikonen commented Dec 5, 2019

#3270

Allow turning off color output using semi-standard "NO_COLOR=xx" and "FORCE_COLOR=0" options

@codecov
Copy link

codecov bot commented Dec 5, 2019

Codecov Report

Merging #3272 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3272      +/-   ##
==========================================
- Coverage   92.76%   92.73%   -0.04%     
==========================================
  Files         170      170              
  Lines        5943     5945       +2     
  Branches     1796     1797       +1     
==========================================
  Hits         5513     5513              
- Misses        225      226       +1     
- Partials      205      206       +1
Impacted Files Coverage Δ
cli/logging.ts 71.42% <0%> (-7.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e92e52...6602406. Read the comment docs.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! I added some tests to push coverage, will merge this as soon as everything runs through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants