Avoid name conflicts when inlining dynamic imports nested in functions #3256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3256 +/- ##
==========================================
+ Coverage 92.74% 92.79% +0.04%
==========================================
Files 170 170
Lines 5925 5923 -2
Branches 1793 1792 -1
==========================================
+ Hits 5495 5496 +1
+ Misses 224 223 -1
+ Partials 206 204 -2
Continue to review full report at Codecov.
|
lukastaegert
force-pushed
the
gh-2345-inlined-dynamic-import-conflict
branch
from
b67b0eb
to
b9ea0e4
Compare
This was referenced Dec 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
resolves #3245
Description
This makes sure that when a dynamic import is used inside a function, variables inside this function are deconflicted with respect to the inlined namespace.