Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken Windows CLI tests #3249

Merged
merged 11 commits into from Nov 22, 2019
Merged

Fix broken Windows CLI tests #3249

merged 11 commits into from Nov 22, 2019

Conversation

lukastaegert
Copy link
Member

@lukastaegert lukastaegert commented Nov 21, 2019

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

As the Windows pipeline does not run for PRs from forks, some Windows CLI tests are now broken on master. This will fix those tests by introducing a helper that automatically strips escape sequences from the output before matching strings. Also, this will refine the batched warning handler and improve coverage.

Furthermore, this will change CLI warnings with two respects:

  • Circular dependency warnings are finally aggregated!
  • All non-aggregated warnings are displayed immediately and not after the build.

cc @tjenkinson

@codecov
Copy link

codecov bot commented Nov 21, 2019

Codecov Report

Merging #3249 into master will increase coverage by 1.42%.
The diff coverage is 93.4%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3249      +/-   ##
==========================================
+ Coverage   91.31%   92.74%   +1.42%     
==========================================
  Files         170      170              
  Lines        5930     5925       -5     
  Branches     1797     1793       -4     
==========================================
+ Hits         5415     5495      +80     
+ Misses        310      224      -86     
- Partials      205      206       +1
Impacted Files Coverage Δ
src/utils/collapseSourcemaps.ts 90% <ø> (+0.98%) ⬆️
src/Graph.ts 92.94% <ø> (ø) ⬆️
cli/run/build.ts 82.92% <100%> (+2.43%) ⬆️
cli/run/batchWarnings.ts 94.16% <93.33%> (+65.13%) ⬆️
src/finalisers/shared/warnOnBuiltins.ts 100% <0%> (+28.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f4f012...8d55118. Read the comment docs.

@lukastaegert lukastaegert force-pushed the fix-windows-tests branch 2 times, most recently from 5378bbb to 08aca10 Compare November 22, 2019 06:38
@lukastaegert lukastaegert marked this pull request as ready for review November 22, 2019 07:54
@lukastaegert lukastaegert merged commit 4eccc99 into master Nov 22, 2019
@lukastaegert lukastaegert deleted the fix-windows-tests branch November 22, 2019 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants