Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not truncate after switch-statement with removed case #3241

Merged
merged 1 commit into from Nov 18, 2019

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #3236

Description

When switch cases were removed, the logic to determine if ALL switch cases contained a return ignored the removed cases. This is fixed now.

@codecov
Copy link

codecov bot commented Nov 18, 2019

Codecov Report

Merging #3241 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3241      +/-   ##
==========================================
+ Coverage   91.26%   91.27%   +<.01%     
==========================================
  Files         170      170              
  Lines        5922     5923       +1     
  Branches     1794     1794              
==========================================
+ Hits         5405     5406       +1     
  Misses        311      311              
  Partials      206      206
Impacted Files Coverage Δ
src/ast/nodes/SwitchStatement.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3885a7f...004f800. Read the comment docs.

@lukastaegert lukastaegert merged commit 690d388 into master Nov 18, 2019
@lukastaegert lukastaegert deleted the gh-3236-no-truncate-after-switch branch November 18, 2019 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch statements: module truncated after empty default case
1 participant