Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do no fail if the source attribute is undefined in an unused named export #3211

Merged
merged 1 commit into from Nov 2, 2019

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #3210

Description

This is a quick fix by changing how Rollup checks for named re-exports, but it is recommended that rollup-plugin-dts improves the ESTree compliance of their generated ASTs.

@codecov
Copy link

codecov bot commented Nov 2, 2019

Codecov Report

Merging #3211 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3211   +/-   ##
=======================================
  Coverage   90.64%   90.64%           
=======================================
  Files         167      167           
  Lines        5909     5909           
  Branches     1792     1792           
=======================================
  Hits         5356     5356           
  Misses        336      336           
  Partials      217      217
Impacted Files Coverage Δ
src/Module.ts 97.31% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cbfdee...adc91a7. Read the comment docs.

@lukastaegert lukastaegert merged commit 33b15cd into master Nov 2, 2019
@lukastaegert lukastaegert deleted the gh-3210-missing-null-in-export branch November 2, 2019 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rollup-plugin-dts triggers a runtime error in rollup core v1.26.0+
1 participant