Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also remove export-all declarations when not tree-shaking #3209

Merged
merged 1 commit into from Oct 31, 2019

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #3196

Description

As exports are always re-rendering in the wrapper, export all declaration should always be removed completely. This basically emulates how it is done for import declarations to work also when tree-shaking is disabled.

@codecov
Copy link

codecov bot commented Oct 31, 2019

Codecov Report

Merging #3209 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3209      +/-   ##
==========================================
+ Coverage   90.63%   90.64%   +<.01%     
==========================================
  Files         167      167              
  Lines        5907     5909       +2     
  Branches     1792     1792              
==========================================
+ Hits         5354     5356       +2     
  Misses        336      336              
  Partials      217      217
Impacted Files Coverage Δ
src/ast/nodes/ExportAllDeclaration.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38c3171...929d2ff. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exports * statements are being retained when treeshake is set to false
1 participant