Make the CLI run generate/output in serial #3201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a temporary workaround for concurrency issues in the plugin driver. See issue rollup#3174
marijnh
force-pushed
the
generate-serially
branch
from
748ac7c
to
31a2c2a
Compare
Codecov Report
@@ Coverage Diff @@
## master #3201 +/- ##
==========================================
+ Coverage 90.63% 90.63% +<.01%
==========================================
Files 167 167
Lines 5905 5906 +1
Branches 1792 1792
==========================================
+ Hits 5352 5353 +1
Misses 336 336
Partials 217 217
Continue to review full report at Codecov.
|
lukastaegert
approved these changes
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a temporary workaround for concurrency issues in the plugin
driver.
See issue #3174
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers: #3174
Description
Until the plugin driver code is updated to handle concurrent use, this makes the CLI tool avoid concurrency to sidestep these problems. This does not help for client code written directly against the programming API, and is intended only to make symptoms less bad until a proper solution is available.