Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exports * statements are being retained when treeshake is set to false #3196

Closed
alan-agius4 opened this issue Oct 28, 2019 · 3 comments · Fixed by #3209
Closed

Exports * statements are being retained when treeshake is set to false #3196

alan-agius4 opened this issue Oct 28, 2019 · 3 comments · Fixed by #3209
Labels
s² 🔥🔥 important t¹ 🐞 bug

Comments

@alan-agius4
Copy link
Contributor

alan-agius4 commented Oct 28, 2019 •
edited

  • Rollup Version: 1.26.0
  • Operating System (or Browser): linux x64 / win32 x64
  • Node Version: v12.9.11 / v12.10.0

How Do We Reproduce?

https://github.com/alan-agius4/rollup-bundle-treeshake-error-3196

Expected Behavior

When treeshake is set to false, export * statements are removed.

Actual Behavior

When treeshake is set to false, export * statements are not being removed which causes an invalid bundle.

Example output:

class Foo {
    
}

export * from './public-api';

export { Foo };
@alan-agius4 alan-agius4 changed the title Exports no longer being bundled Exports no longer being bundled when treeshake is set to false Oct 28, 2019
@alan-agius4 alan-agius4 mentioned this issue Oct 28, 2019
Merged
1 task
@alan-agius4 alan-agius4 changed the title Exports no longer being bundled when treeshake is set to false Exports * statements are being retained when treeshake is set to false Oct 28, 2019
@shellscape
Copy link
Contributor

@alan-agius4 issue template fields are not suggestions, they are required. Please update your issue with the fields you chose to remove.

@alan-agius4
Copy link
Contributor Author

@shellscape updated

kukhariev added a commit to kukhariev/ngx-uploadx that referenced this issue Oct 28, 2019
@kukhariev
build: lock rollup
080d7ff 
rollup/rollup#3196
@CarstenLeue CarstenLeue mentioned this issue Oct 28, 2019
Closed
This was referenced Oct 29, 2019
Merged
Merged
alan-agius4 added a commit to ng-packagr/ng-packagr that referenced this issue Oct 29, 2019
@alan-agius4
fix: lock rollup version
75ac180 
Rollup 1.26.0 introduced a regression see: rollup/rollup#3196

Closes #1431
alan-agius4 added a commit to ng-packagr/ng-packagr that referenced this issue Oct 29, 2019
@alan-agius4
fix: lock rollup version
e80b275 
Rollup 1.26.0 introduced a regression see: rollup/rollup#3196

Closes #1431
@lukastaegert lukastaegert mentioned this issue Oct 31, 2019
Merged
9 tasks
@lukastaegert
Copy link
Member

Fix at #3209

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
s² 🔥🔥 important t¹ 🐞 bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Also remove export-all declarations when not tree-shaking rollup/rollup
3 participants
@shellscape @lukastaegert @alan-agius4