Handle conditional breaks in do-while loops with unconditional return #3180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3180 +/- ##
==========================================
- Coverage 90.19% 90.19% -0.01%
==========================================
Files 165 165
Lines 5907 5905 -2
Branches 1799 1797 -2
==========================================
- Hits 5328 5326 -2
Misses 350 350
Partials 229 229
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
This makes sure that do-while loops get the same treatment as other loops with regard to broken conditional flow to solve this issue:
https://rollupjs.org/repl/?version=1.25.0&shareable=JTdCJTIybW9kdWxlcyUyMiUzQSU1QiU3QiUyMm5hbWUlMjIlM0ElMjJtYWluLmpzJTIyJTJDJTIyY29kZSUyMiUzQSUyMmRvJTIwJTdCJTVDbiUyMCUyMGlmJTIwKGNvbmRpdGlvbiklMjAlN0IlNUNuJTIwJTIwJTIwJTIwYnJlYWslM0IlNUNuJTIwJTIwJTdEJTVDbiU1Q3R0aHJvdyUyMG5ldyUyMEVycm9yKCd0aGlzJTIwb25seSUyMGhhcHBlbnMlMjBpZiUyMCFjb25kaXRpb24nKSUzQiU1Q24lN0QlMjB3aGlsZSUyMCh0cnVlKSUzQiU1Q25jb25zb2xlLmxvZygnd2hlcmUlMjBhbSUyMEkhJTNGJTNGJyklM0IlNUNuJTIyJTJDJTIyaXNFbnRyeSUyMiUzQXRydWUlN0QlNUQlMkMlMjJvcHRpb25zJTIyJTNBJTdCJTIyZm9ybWF0JTIyJTNBJTIyZXNtJTIyJTJDJTIybmFtZSUyMiUzQSUyMm15QnVuZGxlJTIyJTJDJTIyYW1kJTIyJTNBJTdCJTIyaWQlMjIlM0ElMjIlMjIlN0QlMkMlMjJnbG9iYWxzJTIyJTNBJTdCJTdEJTdEJTJDJTIyZXhhbXBsZSUyMiUzQW51bGwlN0Q=