Set null prototype on namespace objects.

[rpamely]

This PR contains:

• bugfix
• feature
• refactor
• documentation
• other

Are tests included?

• yes (bugfixes and features will not be merged without tests)
• no

Breaking Changes?

• yes (breaking changes will not be merged unless absolutely necessary)
• no

List any relevant issue numbers: #3096

Description

Set null prototype on namespace objects by using __proto__. Previously it was not set so used default Object.prototype. ECMAScript spec defines ES module namespaces as exotic objects and says that their [[Prototype]] should be null.

[lukastaegert]

Can you check the remaining test failures? It seems to be just four left

[lukastaegert]

Ah, now it is running :)

[lukastaegert]

And sorry, there are some conflicts with master now 🙄

[codecov]

Codecov Report

Merging #3136 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3136      +/-   ##
==========================================
+ Coverage   89.31%   89.31%   +<.01%     
==========================================
  Files         165      165              
  Lines        5726     5727       +1     
  Branches     1737     1737              
==========================================
+ Hits         5114     5115       +1     
  Misses        379      379              
  Partials      233      233

Impacted Files	Coverage Δ
src/ast/variables/NamespaceVariable.ts	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1ec55c...d7b0e41. Read the comment docs.

[rpamely]

@lukastaegert Think it's good now, tests are passing!

[lukastaegert]

👍