Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wire up --context CLI flag #3134

Merged
merged 1 commit into from Sep 26, 2019
Merged

Conversation

tchetwin
Copy link
Contributor

Fixes #3121

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

#3121

Description

It looks like --context was not wired up in mergeOptions. Using the createGetOption helper to check both the config and command line options.

@codecov
Copy link

codecov bot commented Sep 26, 2019

Codecov Report

Merging #3134 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3134      +/-   ##
==========================================
+ Coverage   89.28%   89.32%   +0.03%     
==========================================
  Files         165      165              
  Lines        5732     5732              
  Branches     1741     1741              
==========================================
+ Hits         5118     5120       +2     
+ Misses        380      379       -1     
+ Partials      234      233       -1
Impacted Files Coverage Δ
src/utils/mergeOptions.ts 90.47% <ø> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a261cad...2943faa. Read the comment docs.

@tchetwin tchetwin marked this pull request as ready for review September 26, 2019 14:58
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rollup CLI --context flag seems broken
2 participants