Preserve empty for...of loops #3132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/ast/nodes/ForOfStatement.ts
Outdated
| // this.left.hasEffectsWhenAssignedAtPath(EMPTY_PATH, options))) || | ||
| // (this.right && this.right.hasEffects(options)) || | ||
| // this.body.hasEffects(options.setIgnoreBreakStatements()) | ||
| // ); |
There was a problem hiding this comment.
Could you get rid of the commented code and commented import?
lukastaegert
requested changes
Sep 26, 2019
| : { done: true }; | ||
|
|
||
| // assert later | ||
| global.foo = this.current; |
There was a problem hiding this comment.
A cooler way than mutating a global and testing our test isolation would be to export a mutable export let ... binding and checking that.
|
Also, I fear to greater part of work would be to adapt the existing test suite |
Codecov Report
@@ Coverage Diff @@
## master #3132 +/- ##
==========================================
- Coverage 89.32% 89.32% -0.01%
==========================================
Files 165 165
Lines 5732 5731 -1
Branches 1741 1740 -1
==========================================
- Hits 5120 5119 -1
Misses 379 379
Partials 233 233
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers: fixes #3126
Description
Since there is no proper support for Symbol.Iterator, drop the side effect (but don't remove) the algorithm such that iterators with side-effects are not omitted.