Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not create conflicts between files emitted in generateBundle for different outputs #3098

Closed
lukastaegert opened this issue Sep 6, 2019 · 3 comments · Fixed by #3218
Closed

Comments

@lukastaegert
Copy link
Member

lukastaegert commented Sep 6, 2019

  • Rollup Version: 1.20.3
  • Operating System (or Browser): Any
  • Node Version: 12

How Do We Reproduce?

Taken from #2999 (comment):
Note that I did not verify this myself, but I do not want this to go unnoticed cc @wessberg

Expected Behavior

When creating several outputs and emitting files in generateBundle using the fileName option, the files are unique to each output and there are not conflicts between outputs.

Actual Behavior

Apparently, files in later outputs cannot be generated with the same name but will throw a name conflict error.

@wessberg
Copy link
Contributor

wessberg commented Nov 7, 2019

This issue was resolved in #3174 and released in v1.26.1.

@lukastaegert
Copy link
Member Author

Unfortunately not completely. You can still create conflicts via the JS API. But the real fix is around the corner.

@wessberg
Copy link
Contributor

wessberg commented Nov 7, 2019

For what it's worth, the problem I initially reported which involved using the emitFile API went away with v1.26.1. Keep up the good work Lukas, you're awesome! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants