Fixes type definition on watch and Watcher constructor. #3074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As seen on line 42, this function actually accepts either a `GenericConfigObject[]` or a `GenericConfigObject`. The documentation uses the non-array form, which results in a user following the documentation in TypeScript getting a type checker error.
Codecov Report
@@ Coverage Diff @@
## master #3074 +/- ##
======================================
Coverage 88.8% 88.8%
======================================
Files 165 165
Lines 5728 5728
Branches 1743 1743
======================================
Hits 5087 5087
Misses 388 388
Partials 253 253
Continue to review full report at Codecov.
|
shellscape
approved these changes
Aug 22, 2019
There was a problem hiding this comment.
Approved. According to https://www.rollupjs.org/guide/en/#rollupwatch:
The watchOptions argument is a config (or an array of configs) that you would export from a config file.
lukastaegert
approved these changes
Aug 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
Description
As seen on line 42, this function actually accepts either a
GenericConfigObject[]or aGenericConfigObject. The documentation uses the non-array form, which results in a user following the documentation in TypeScript getting a type checker error.