Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong variable name in import expression #3073

Merged
merged 3 commits into from Aug 22, 2019

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #3072

Description

Import expressions did not properly render their source, which meant that variable name changes could be lost.

@codecov
Copy link

codecov bot commented Aug 22, 2019

Codecov Report

Merging #3073 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3073      +/-   ##
==========================================
+ Coverage    88.8%   88.81%   +<.01%     
==========================================
  Files         165      165              
  Lines        5728     5729       +1     
  Branches     1743     1743              
==========================================
+ Hits         5087     5088       +1     
  Misses        388      388              
  Partials      253      253
Impacted Files Coverage Δ
src/ast/nodes/ImportExpression.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0314917...052f395. Read the comment docs.

@lukastaegert lukastaegert marked this pull request as ready for review August 22, 2019 07:17
@lukastaegert lukastaegert changed the title [WIP] Fix wrong variable name in import expression Fix wrong variable name in import expression Aug 22, 2019
@lukastaegert lukastaegert merged commit 372101f into master Aug 22, 2019
@lukastaegert lukastaegert deleted the gh-3072-await-import-expression branch August 22, 2019 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when using await import()
2 participants