Prevent infinite loop when scanning for line-breaks and there are comment-like strings

[lukastaegert]

This PR contains:

• bugfix
• feature
• refactor
• documentation
• other

Are tests included?

• yes (bugfixes and features will not be merged without tests)
• no

Breaking Changes?

• yes (breaking changes will not be merged unless absolutely necessary)
• no

List any relevant issue numbers:
Resolves #3067

Description

When fixing invalid generated code when simplifying return statement, a new bug was introduced because scanning for line-breaks would not always terminate properly when there were strings in the code that looked like comments. This is fixed here.

See #3067 (comment) for more info.

[codecov]

Codecov Report

Merging #3069 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #3069      +/-   ##
=========================================
+ Coverage   88.75%   88.8%   +0.05%     
=========================================
  Files         165     165              
  Lines        5737    5728       -9     
  Branches     1748    1743       -5     
=========================================
- Hits         5092    5087       -5     
  Misses        388     388              
+ Partials      257     253       -4

Impacted Files	Coverage Δ
src/utils/renderHelpers.ts	100% <100%> (+5.55%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 852e704...a0bf53e. Read the comment docs.

[shellscape]

Changes look good from my end.

I don't know enough about this part of the code to know if it would be an issue, but would regular expressions get caught by the last commit?

[lukastaegert]

Technically yes, just as the division operator or special strings would be caught. The point is that all of these functions are only called in scenarios where there is at most whitespace and comments in the searched range so they should be save. But of course this needs to be considered in all places where they are used. However I believe this "hidden" contract should be acceptable considering all of them are highly performance critical.

[shellscape]

Shippppp it

[lukastaegert]

Definitely! Will trigger it now...