Aggregating modules fails when exporting default from another module along with other named exports

[ravijayaramappa]

• Rollup Version: 1.7.4
• Operating System (or Browser): macOS Mojave
• Node Version: 10.16.0

How Do We Reproduce?

When an aggregating module exports the default from another module along with named properties from a different module, the generated output will through a ReferenceError upon invocation.

Example:

export { default } from 'x/foo';
export { namedProp } from 'x/bar';

REPL repro

Importing a default and named export from the same module seems to work fine ✅
Example:

export { default, namedProp } from 'x/foo';

Expected Behavior

amd format

define(['exports', 'x/foo', 'x/bar'], function (exports, foo, bar) { 'use strict';
	foo = foo && foo.hasOwnProperty('default') ? foo['default'] : foo;

	exports.default = foo;
	Object.defineProperty(exports, 'namedProp', {
		enumerable: true,
		get: function () {
			return bar.namedProp;
		}
	});
	Object.defineProperty(exports, '__esModule', { value: true });
});

Actual Behavior

amd format

define(['exports', 'x/foo', 'x/bar'], function (exports, foo, bar) { 'use strict';
	foo = foo && foo.hasOwnProperty('default') ? foo['default'] : foo;

	exports.default = foo__default; // <-- this will result in a ReferenceError
	Object.defineProperty(exports, 'namedProp', {
		enumerable: true,
		get: function () {
			return bar.namedProp;
		}
	});
	Object.defineProperty(exports, '__esModule', { value: true });
});

This could be related to a similar issue reported prior: #2977

[lukastaegert]

It is certainly related to #2977 but it seems to manifest slightly differently so I will keep it as a separate issue. Hope we can fix them together soon!

[lukastaegert]

I’m working on a fix for this but due to other issues it may take another week to complete.

[lukastaegert]

Fix at #3084