New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deconflict unused parameters #2972

Merged

lukastaegert merged 1 commit into master from gh-2970-unused-parameter-conflict

Jun 29, 2019

Member

lukastaegert commented Jun 29, 2019

This PR contains:

Are tests included?

yes (bugfixes and features will not be merged without tests)
no

Breaking Changes?

yes (breaking changes will not be merged unless absolutely necessary)
no

List any relevant issue numbers:
Resolves #2970

Description

As treeshaken parameters were still rendered, this could cause conflicts with other variables. This PR fixes this.


          Deconflict unused parameters

c1b124d

lukastaegert mentioned this pull request

Regression in 1.14.0 with imports and unused parameters #2970

Closed

lukastaegert merged commit 9fb1a48 into master

lukastaegert deleted the gh-2970-unused-parameter-conflict branch

June 29, 2019 05:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment