dynamic import catch handler not firing on failure

[dnalborczyk]

• Rollup Version: v1.15.6, v1.16.1
• Operating System (or Browser): n/a
• Node Version: v12.4.0

How Do We Reproduce?

import('./foo.js').catch((e) => {
  // catch error here
});

when bundled to commonjs:

// commonjs
Promise.resolve(require('./foo.js')).catch((e) => {
  // catch error here
  // will never execute if ./foo.js doesn't exist
})

Promise.resolve takes only a value, not an expression. I think rollup should either use:

Promise.resolve().then(() => require('./foo.js'))

or the Promise constructor:

new Promise((res) => res(require('./foo.js')))

[lukastaegert]

Good point. Yes, an import error would not be caught by Promise.resolve.

[lukastaegert]

Fix at #2958

[dnalborczyk]

@lukastaegert awesome, thanks!!