New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect typing for resolveId hook #2939
Comments
According to my tests, it looks like the the typings are actually incorrect. |
I must admit that I was under the impression that |
In my opinion, the I would suggest to use the The |
This is a religious debate. Others could argue that |
Hello!
Thank you for this great tool!
However, right now, typing for the
resolveId
hook contradicts the documentation.According to the docs:
However, in
rollup.d.ts
there is the following type:export type ResolveIdResult = string | false | void | PartialResolvedId;
There is no
null
return value. This happend after I've updated the Rollup dependency to the latest version. Previously my code was working fine with returningnull
.What exactly has changed? Should we update the documentation (and the behavior of all plugins) or the typing is just incorrect?
Thanks!
The text was updated successfully, but these errors were encountered: