Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly include try statements for each pass when deoptimization is deactivated #2914

Merged
merged 1 commit into from Jun 10, 2019

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #2913

Description

When tryCatchDeoptimization is deactivated, we need to run include on all children of the try statement for each tree-shaking pass, not only for the first (this is how it works for all other nodes). This caused e.g. call parameters to vanish but other effects could have been caused by this as well.

@lukastaegert lukastaegert merged commit 9abcb7e into master Jun 10, 2019
@lukastaegert lukastaegert deleted the gh-2913-deoptimized-call-parameters branch June 10, 2019 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All call parameters are treeshaken with tryCatchDeoptimization: false
1 participant