Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle early bind for member expressions #2900

Merged

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #2895

Description

When binding namespace members, it could happen that the base variable was bound to a variable before the member expression which could lead to the namespace being needlessly included later.

@lukastaegert lukastaegert merged commit 16324f1 into master Jun 5, 2019
@lukastaegert lukastaegert deleted the gh-2895-handle-early-bind-for-member-expressions branch June 5, 2019 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

esm output leaves behind dead namespace import
1 participant