Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow transformers to return an empty string #2861

Merged
merged 1 commit into from May 16, 2019

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #2859

Description

As a regression of the latest release, transformers returning an empty string were treated as if they returned null and were therefore ignored. This broke Sapper.

@lukastaegert lukastaegert merged commit 33eba89 into master May 16, 2019
@lukastaegert lukastaegert deleted the gh-2859-transform-empty-string branch May 16, 2019 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in v1.12.0 release
2 participants