Make sure circular export * from X does not stack overflow
#2836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great on first glance, unfortunately I have to quit working for today, hope to continue some time tomorrow |
Swatinem
force-pushed
the
circular-export-star
branch
2 times, most recently
from
6b9004e
to
8b31835
Compare
lukastaegert
reviewed
May 4, 2019
Swatinem
force-pushed
the
circular-export-star
branch
from
8b31835
to
07a1dea
Compare
lukastaegert
approved these changes
May 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
closes #2815
Description
Circular
export * from Xused to lead to a stack overflow. This Fix avoids that by keeping track of already walked modules. Not sure if this is the right place for such a fix?