Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add es3 support for namespace object import #2825

Merged
merged 2 commits into from May 5, 2019
Merged

Conversation

sormy
Copy link
Contributor

@sormy sormy commented Apr 28, 2019

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

#2591

Description

Add ES3 support for namespace import. All other es3 compatibility issues I'm aware of could be fixed with polyfills and babel.

@sormy
Copy link
Contributor Author

sormy commented Apr 30, 2019

Ping! ;-)

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks essentially good, would just be nice to align the reserved words with the existing ones.

src/ast/utils/isReservedWord.ts Outdated Show resolved Hide resolved
@sormy sormy force-pushed the master branch 2 times, most recently from 3f6547d to 8ec8c1c Compare May 2, 2019 17:45
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, missed your last changes, looks great!

@lukastaegert lukastaegert merged commit dee790e into rollup:master May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants