Catch invalid options.format values #2813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay, yeah, see my PR #2814 wrt to the failing CI run. |
lukastaegert
requested changes
Apr 19, 2019
There was a problem hiding this comment.
Looks technically ok to me except that internally, 'esm' is actually mapped to 'es' so you should check for that instead (which is why so many tests are breaking). The reason is that this is what was used by plugins before we changed to 'esm' .
The error message may be misleading but it correctly lists the currently recommended alias 'esm' (though there is a chance we will switch to 'module' in the future)
Before, it'd nebulously crash when trying to dereference RESERVED_NAMES_BY_FORMAT instead. (It'd be nice if the formats were centrally defined, but since they aren't I decided to just add another list.)
|
I can't get the tests to pass either way (a lot of them time out) locally, so I've force-pushed just to see what the CI makes of it. |
|
Seems that CI likes it! |
lukastaegert
approved these changes
Apr 19, 2019
lukastaegert
approved these changes
Apr 19, 2019
TrySound
reviewed
Apr 19, 2019
| @@ -34,7 +34,7 @@ function checkOutputOptions(options: OutputOptions) { | |||
| }); | |||
| } | |||
|
|
|||
| if (!options.format) { | |||
| if (['amd', 'cjs', 'system', 'es', 'iife', 'umd'].indexOf(options.format) < 0) { | |||
There was a problem hiding this comment.
Never mind. I saw Lukas comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, it'd nebulously crash when trying to dereference
RESERVED_NAMES_BY_FORMATinstead.(It'd be nice if the formats were centrally defined, but since they aren't I decided to just add another list.)
This PR contains:
Are tests included?
Breaking Changes?