Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline comments for dynamic imports are removed starting with rollup 1.4.0 #2778

Closed
BryceMehring opened this issue Mar 25, 2019 · 2 comments
Closed

Comments

@BryceMehring
Copy link

  • Rollup Version: 1.7.3
  • Operating System (or Browser): MacOS 10.13.6
  • Node Version: v11.12.0

How Do We Reproduce?

Rollup 1.3.3 does not remove comments within dynamic import statements. Rollup 1.4.0 and above removes comments from dynamic import statements. For example:

import(/* webpackChunkName: "chunk-name" */ 'some-module')

the comment will be removed in the bundle

Expected Behavior

Comments within the dynamic import should not be removed in the bundle.

Actual Behavior

Comments are being removed within the dynamic module import.

manucorporat added a commit to manucorporat/rollup that referenced this issue Apr 8, 2019
@manucorporat
Copy link
Contributor

manucorporat commented Apr 8, 2019

@lukastaegert prepared a PR! #2797 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants