Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue where the same hash was generated when different variables were exported under the same name #2741

Merged
merged 1 commit into from Mar 7, 2019

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

The previous hashing algorithm only took generated export names in account which caused hash conflicts if different variables were exported using the same names via e.g. export {foo} vs. export {bar as foo}. The new algorithm now takes three things into account:

  • the exported name
  • the original variable name in the source
  • the module this variable belongs to (as only in this context, the top level variable name is unique);

@lukastaegert lukastaegert force-pushed the improve-hashing branch 2 times, most recently from bce6a71 to 55e4d5f Compare March 6, 2019 06:52
@lukastaegert lukastaegert merged commit af41561 into master Mar 7, 2019
@lukastaegert lukastaegert deleted the improve-hashing branch March 7, 2019 05:13
@lukastaegert lukastaegert changed the title Fix an issue where the same hash was generated when different variables where exported under the same name Fix an issue where the same hash was generated when different variables were exported under the same name Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant