Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always recreate paths for external modules #2706

Merged
merged 2 commits into from Feb 19, 2019

Conversation

lukastaegert
Copy link
Member

@lukastaegert lukastaegert commented Feb 18, 2019

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #2675

Description

There is a bug where if different outputs use different paths for external dependencies, then the path used by the first output is used for all other outputs as well. This fixes this by recreating the path for each output.

@lukastaegert lukastaegert merged commit 0e4fe6f into master Feb 19, 2019
@lukastaegert lukastaegert deleted the gh-2675-multiple-render-paths branch February 19, 2019 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ExternalModule renderPath doesn't change with multiple outputs?
1 participant