Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tree-shaken dynamic imports leave behind undefined in bundle #2659

Closed
tivac opened this issue Jan 16, 2019 · 1 comment · Fixed by #2663
Closed

Tree-shaken dynamic imports leave behind undefined in bundle #2659

tivac opened this issue Jan 16, 2019 · 1 comment · Fixed by #2663
Labels
t¹ 🐞 bug

Comments

@tivac
Copy link
Contributor

tivac commented Jan 16, 2019

When a dynamic import is removed via tree-shaking it leaves an undefined behind in the Bundle object that is passed to the generateBundle plugin hook. This seems unintended and can cause bugs in plugins that use that data like @modular-css/rollup.

  • Rollup Version: 1.1.0
  • Operating System (or Browser): Windows 10
  • Node Version: 10.12.0

How Do We Reproduce?

I made a gist. The README.md contains repro steps.

Expected Behavior

The Bundle object passed to generateBundle shouldn't have an undefined value inside of the dynamicImports array when a dynamic import is removed by tree-shaking.

Actual Behavior

The Bundle object passed to generateBundle has an undefined value inside of the dynamicImports array when a dynamic import is removed by tree-shaking.
tivac added a commit to tivac/modular-css that referenced this issue Jan 16, 2019
@tivac
fix: don't add invalid deps
2176ead 
Work around rollup/rollup#2659
@tivac tivac mentioned this issue Jan 16, 2019
Merged
9 tasks
tivac added a commit to tivac/modular-css that referenced this issue Jan 16, 2019
@tivac
fix: handle dynamic imports removed by tree-shaking (#538)
c2a09e1 
Work around rollup/rollup#2659
@lukastaegert lukastaegert mentioned this issue Jan 19, 2019
Merged
9 tasks
@lukastaegert
Copy link
Member

Thanks for the nice repro! Fix at #2663.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
t¹ 🐞 bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Completely remove tree-shaken dynamic imports from bundle information rollup/rollup
2 participants
@tivac @lukastaegert