New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure object prototype methods are not considered to be falsy #2652

Merged

lukastaegert merged 1 commit into master from truthy-prototype-methods

Jan 19, 2019

Member

lukastaegert commented Jan 12, 2019

This PR contains:

Are tests included?

yes (bugfixes and features will not be merged without tests)
no

Breaking Changes?

yes (breaking changes will not be merged unless absolutely necessary)
no

List any relevant issue numbers:
Resolves #2651

Description

This will make sure that when checking the value of object expression members, builtin prototype methods will not be considered to be falsy


          Make sure object prototype methods are not considered to be falsy

b184ae8

lukastaegert mentioned this pull request

Treeshaking trying to evaluate non-constant expressions #2651

Closed

lukastaegert merged commit cb3829b into master

lukastaegert deleted the truthy-prototype-methods branch

January 19, 2019 20:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment