Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document and fix this.addWatchFile plugin context function #2633

Merged
merged 1 commit into from Jan 5, 2019

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Closes #2619

Description

This PR documents the this.addWatchFile plugin context function. It also fixes the behaviour that if a transform hook uses this function, it will be rerun whenever the watched file changes.

Moreover, a few more tests for this were added.

Also fixes some inconsistencies in the changelog.

@tivac
Copy link
Contributor

tivac commented Jan 4, 2019

Thank you for documenting this!

This change to ensure that the calling hook gets invoked again on changes might've made my changes for rollup@1 support redundant. 😅 It sounds more in-line w/ the previous behavior though so I'm a big fan 👍🏻

@lukastaegert lukastaegert force-pushed the add-watch-file-documentation-and-fixes branch from 542f0a4 to ebb6a83 Compare January 4, 2019 08:02
fix some error messages and inconsistencies in the changelog and+
document this.addWatchFile
@lukastaegert lukastaegert force-pushed the add-watch-file-documentation-and-fixes branch from ebb6a83 to 584fdab Compare January 4, 2019 08:17
@Conduitry
Copy link
Contributor

👍 Nice, thank you!

@lukastaegert lukastaegert merged commit 6b343ab into master Jan 5, 2019
@lukastaegert lukastaegert deleted the add-watch-file-documentation-and-fixes branch January 5, 2019 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Watching/dependency documentation out of date
3 participants