Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Watching/dependency documentation out of date #2619

Closed
3 of 4 tasks
Conduitry opened this issue Dec 29, 2018 · 1 comment · Fixed by #2633
Closed
3 of 4 tasks

Watching/dependency documentation out of date #2619

Conduitry opened this issue Dec 29, 2018 · 1 comment · Fixed by #2633
Labels
t² 📚 documentation

Comments

@Conduitry
Copy link
Contributor

Documentation Is:

  • Missing
  • Needed
  • Confusing
  • Not Sure?

Please Explain in Detail...

The 1.0.0 changelog implies that the deprecated dependencies value in the response from the transform hook has been replaced by watchChange hook, which does not seem accurate. The actual deprecation message displayed by Rollup indicates that this.addWatchFile should be used, which does sound more likely to be correct. However, this.addWatchFile is not documented in the guide.

Your Proposal for Changes

The changelog should indicate that this.addWatchFile is the replacement for dependencies. The guide should mention how to use this.addWatchFile.
@lukastaegert lukastaegert mentioned this issue Jan 4, 2019
Merged
9 tasks
@lukastaegert
Copy link
Member

Fix at #2633

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
t² 📚 documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Document and fix this.addWatchFile plugin context function rollup/rollup
2 participants
@lukastaegert @Conduitry