Take dynamic dependencies into account when calculating hashes #2596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukastaegert
force-pushed
the
invalidate-hash-dynamic-dependencies
branch
from
d6021ac
to
50eb217
Compare
guybedford
reviewed
Dec 16, 2018
| private computeContentHashWithDependencies(addons: Addons, options: OutputOptions): string { | ||
| const hash = sha256(); | ||
|
|
||
| // own rendered source, except for finalizer wrapping | ||
| hash.update(this.getRenderedHash()); |
There was a problem hiding this comment.
We do need the rendered hash of the source itself here. How else would changing the source without changing any other dependency information change the hash?
There was a problem hiding this comment.
The rendered hash is added in visitDependencies. I made a note to add a new test category at some point to prove this is actually the case.
There was a problem hiding this comment.
It might be somewhat confusing, though, that visitDependencies always visits the base chunk first. Maybe the name should be improved.
This was referenced Aug 31, 2019
This was referenced Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolves #2435
Description
Previously, hashes were only based on the file content and the content of all static dependencies.
This will also take dynamic dependencies into account.