Do not resolve external dynamic imports via plugins #2505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guybedford
reviewed
Oct 15, 2018
src/utils/pluginDriver.ts
Outdated
| return pluginDriver.hookFirst('resolveId', [id, parent]); | ||
| return this.isExternal(id, parent, false) | ||
| ? false | ||
| : pluginDriver.hookFirst('resolveId', [id, parent]); |
There was a problem hiding this comment.
This logic is now duplicated with https://github.com/rollup/rollup/blob/master/src/Graph.ts#L783.
I would prefer if we could keep the separation for all calls the same I think.
|
@guybedford I moved the external check for dynamic imports into the default plugin handler for the resolve dynamic import hook. I guess this does make more sense though there is still some duplication between dynamic and non-dynamic import resolution. Please tell me, if this would work for you. |
|
Will merge this for now in its changed form as this definitely needs fixing. Feel free to add further comments to this PR if the current solution should be further improved. |
guybedford
reviewed
Nov 4, 2018
This was referenced Aug 31, 2019
This was referenced Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolve #2481
Resolve #2487 (probably)
Description
Before refactoring the plugin system, external ids would never be passed to plugin hooks for further resolution. This was broken for the resolution of dynamic imports.
This restores the old logic up to v0.64.1