Properly deconflict ids of default exports that have been reassigned #2502
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolves #2414
Description
See also #2414. The logic for handling default exports of function and class declarations did not properly take into account that those not only declare a local variable as well but that reassigning this local variable will reassign the default export. Cf. these examples:
vs.
Previously, only the first case was handled properly while this PR also handles the second case right. This also cleans up some logic so that almost everything related to default exports with ids is now handled together in
ExportDefaultVariable
.