Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic imports are always emitted #2444

Closed
manucorporat opened this issue Sep 5, 2018 · 3 comments · Fixed by #2575
Closed

Dynamic imports are always emitted #2444

manucorporat opened this issue Sep 5, 2018 · 3 comments · Fixed by #2575
Labels
t³ ✨ enhancement

Comments

@manucorporat
Copy link
Contributor

manucorporat commented Sep 5, 2018 •
edited

  • Rollup Version: 0.65.1
  • Operating System (or Browser):
  • Node Version:

How Do We Reproduce?

screenshot 2018-09-05 at 19 36 18

Expected Behavior

The emitted JS should be empty

Actual Behavior

It's not empty

Note

Probably a duplicate of: #2284
Sharing REPL is not working to me
@manucorporat manucorporat changed the title Dynamic imports are Dynamic imports are always emitted Sep 5, 2018
@lukastaegert
Copy link
Member

Yes, this is a known issue. I hope we can fix it in the future, there are some tree-shaking improvements that will need to come first, though.

@manucorporat
Copy link
Contributor Author

Thanks for the info! Hope it gets resolved soon 💪

@manucorporat manucorporat mentioned this issue Dec 2, 2018
Merged
9 tasks
@lukastaegert
Copy link
Member

Fix at #2575

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
t³ ✨ enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor chunking algorithm rollup/rollup
2 participants
@manucorporat @lukastaegert