Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static if statements fail to build in specific cases. #2134

Closed
dereli opened this issue Apr 18, 2018 · 4 comments · Fixed by #2146
Closed

Static if statements fail to build in specific cases. #2134

dereli opened this issue Apr 18, 2018 · 4 comments · Fixed by #2146
Labels
t¹ 🐞 bug

Comments

@dereli
Copy link

dereli commented Apr 18, 2018

Issue description is super simple: static else if statements throws error. check the REPL.

TypeError: Cannot read property 'start' of null
    at IfStatement.render (/project/node_modules/rollup/dist/rollup.js:15196:52)
    at IfStatement.NodeBase.render (/project/node_modules/rollup/dist/rollup.js:13610:23)
    at IfStatement.render (/project/node_modules/rollup/dist/rollup.js:15191:37)
    at renderStatementList (/project/node_modules/rollup/dist/rollup.js:13702:25)
@jthoms1
Copy link

jthoms1 commented Apr 19, 2018

We have had at least 3 separate reports in Stenciljs Slack of this issue. All seemed to stem from the same use case as reported here.

@jgw96 jgw96 mentioned this issue Apr 19, 2018
Closed
@manucorporat
Copy link
Contributor

Same here:

TypeError: Cannot read property 'start' of null at IfStatement.render
           (/Users/manuelmartinez-almeida/repos/death-rate/node_modules/rollup/dist/rollup.js:15204:52) at
           IfStatement.NodeBase.render
           (/Users/manuelmartinez-almeida/repos/death-rate/node_modules/rollup/dist/rollup.js:13611:23) at
           IfStatement.render
           (/Users/manuelmartinez-almeida/repos/death-rate/node_modules/rollup/dist/rollup.js:15199:37) at
           renderStatementList
           (/Users/manuelmartinez-almeida/repos/death-rate/node_modules/rollup/dist/rollup.js:13709:25) at
           BlockStatement.render
           (/Users/manuelmartinez-almeida/repos/death-rate/node_modules/rollup/dist/rollup.js:14500:13) at
           IfStatement.NodeBase.render
           (/Users/manuelmartinez-almeida/repos/death-rate/node_modules/rollup/dist/rollup.js:13611:23) at
           IfStatement.render
           (/Users/manuelmartinez-almeida/repos/death-rate/node_modules/rollup/dist/rollup.js:15199:37) at
           renderStatementList
           (/Users/manuelmartinez-almeida/repos/death-rate/node_modules/rollup/dist/rollup.js:13709:25) at
           BlockStatement.render
           (/Users/manuelmartinez-almeida/repos/death-rate/node_modules/rollup/dist/rollup.js:14500:13) at
           FunctionExpression.NodeBase.render
           (/Users/manuelmartinez-almeida/repos/death-rate/node_modules/rollup/dist/rollup.js:13611:23)

lukastaegert added a commit that referenced this issue Apr 21, 2018
@lukastaegert
Improve if statement rendering; resolves #2134
3d4fda0
@lukastaegert lukastaegert mentioned this issue Apr 21, 2018
Merged
@lukastaegert
Copy link
Member

Thanks for posting this and sorry for the inconvenience. Fix at #2146

@dereli
Copy link
Author

dereli commented Apr 23, 2018

@lukastaegert, thanks for quick action and for all the efforts.

@steve-taylor steve-taylor mentioned this issue Aug 6, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
t¹ 🐞 bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve if statement rendering rollup/rollup
5 participants
@manucorporat @guybedford @jthoms1 @lukastaegert @dereli