From 08b61f5e1df9532ae538c1d2c782de310a2ced44 Mon Sep 17 00:00:00 2001 From: dnalborczyk Date: Mon, 2 Jan 2023 02:50:12 -0500 Subject: [PATCH] Remove array grouping (web compat issue) (#4779) Co-authored-by: Lukas Taegert-Atkinson --- src/ast/nodes/shared/ArrayPrototype.ts | 2 -- .../builtin-prototypes/array-expression/_expected.js | 8 -------- .../builtin-prototypes/array-expression/main.js | 12 ------------ 3 files changed, 22 deletions(-) diff --git a/src/ast/nodes/shared/ArrayPrototype.ts b/src/ast/nodes/shared/ArrayPrototype.ts index 27592ecd13a..008ac82acad 100644 --- a/src/ast/nodes/shared/ArrayPrototype.ts +++ b/src/ast/nodes/shared/ArrayPrototype.ts @@ -133,8 +133,6 @@ export const ARRAY_PROTOTYPE = new ObjectEntity( flat: METHOD_DEOPTS_SELF_RETURNS_NEW_ARRAY, flatMap: METHOD_CALLS_ARG_DEOPTS_SELF_RETURNS_NEW_ARRAY, forEach: METHOD_CALLS_ARG_DEOPTS_SELF_RETURNS_UNKNOWN, - group: METHOD_CALLS_ARG_DEOPTS_SELF_RETURNS_UNKNOWN, - groupToMap: METHOD_CALLS_ARG_DEOPTS_SELF_RETURNS_UNKNOWN, includes: METHOD_RETURNS_BOOLEAN, indexOf: METHOD_RETURNS_NUMBER, join: METHOD_RETURNS_STRING, diff --git a/test/form/samples/builtin-prototypes/array-expression/_expected.js b/test/form/samples/builtin-prototypes/array-expression/_expected.js index a7bfe69b85e..4fea44f0ad9 100644 --- a/test/form/samples/builtin-prototypes/array-expression/_expected.js +++ b/test/form/samples/builtin-prototypes/array-expression/_expected.js @@ -55,14 +55,6 @@ _flatMapArray[0].effect(); const _forEachArray = [{ effect() {} }]; _forEachArray.forEach(element => (element.effect = () => console.log(1))); _forEachArray[0].effect(); -[1].group(() => console.log(1) || true); -const _groupArray = [{ effect() {} }]; -_groupArray.group((_, element) => (element.effect = () => console.log(1))); -_groupArray[0].effect(); -[1].groupToMap(() => console.log(1) || true); -const _groupToMapArray = [{ effect() {} }]; -_groupToMapArray.group((_, element) => (element.effect = () => console.log(1))); -_groupToMapArray[0].effect(); [1].map(() => console.log(1) || 1); const _mapArray = [{ effect() {} }]; _mapArray.map(element => (element.effect = () => console.log(1))); diff --git a/test/form/samples/builtin-prototypes/array-expression/main.js b/test/form/samples/builtin-prototypes/array-expression/main.js index e15ebe20e05..3cf1b47ca43 100644 --- a/test/form/samples/builtin-prototypes/array-expression/main.js +++ b/test/form/samples/builtin-prototypes/array-expression/main.js @@ -104,18 +104,6 @@ const _forEachArray = [{ effect() {} }]; _forEachArray.forEach(element => (element.effect = () => console.log(1))); _forEachArray[0].effect(); -const _group = [1].group(() => true); -const _groupEffect = [1].group(() => console.log(1) || true); -const _groupArray = [{ effect() {} }]; -_groupArray.group((_, element) => (element.effect = () => console.log(1))); -_groupArray[0].effect(); - -const _groupToMap = [1].groupToMap(() => true); -const _groupToMapEffect = [1].groupToMap(() => console.log(1) || true); -const _groupToMapArray = [{ effect() {} }]; -_groupToMapArray.group((_, element) => (element.effect = () => console.log(1))); -_groupToMapArray[0].effect(); - const _map = [1].map(() => 1).join(','); const _mapEffect = [1].map(() => console.log(1) || 1); const _mapArray = [{ effect() {} }];