You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Version 5, intended as the 'Rollup 1.0' version, still has dependencies return from the transform hook.
This was code written by me, to allow preprocessors to return additional watch dependencies. The API selected for the preprocessors was based on the old Rollup API for the transform hook, but probably it makes the most sense to still have dependencies be an array returned by the preprocessor?
this.addWatchFile is not mentioned in the Rollup changelog as far as I can see, but it looks like it is not present in 0.60.0, which is what's listed as a peer dependency of this plugin. So, despite rollup-plugin-svelte@5 being intended as the rollup@1 update, it should probably be considered breaking to assume this.addWatchFile is present.
So I think we can instead then just look for the truthiness of this.addWatchFile, call that if it's present, and otherwise put dependencies on the object returned by transform.
Sorry this issue description is so much longer than it needs to be.
The text was updated successfully, but these errors were encountered:
Version 5, intended as the 'Rollup 1.0' version, still has
dependencies
return from thetransform
hook.This was code written by me, to allow preprocessors to return additional watch dependencies. The API selected for the preprocessors was based on the old Rollup API for the
transform
hook, but probably it makes the most sense to still havedependencies
be an array returned by the preprocessor?this.addWatchFile
is not mentioned in the Rollup changelog as far as I can see, but it looks like it is not present in 0.60.0, which is what's listed as a peer dependency of this plugin. So, despite rollup-plugin-svelte@5 being intended as the rollup@1 update, it should probably be considered breaking to assumethis.addWatchFile
is present.So I think we can instead then just look for the truthiness of
this.addWatchFile
, call that if it's present, and otherwise putdependencies
on the object returned bytransform
.Sorry this issue description is so much longer than it needs to be.
The text was updated successfully, but these errors were encountered: