Skip to content
This repository has been archived by the owner on Aug 4, 2021. It is now read-only.

replace buble with babel, update deps #216

Merged
merged 3 commits into from May 11, 2019
Merged

replace buble with babel, update deps #216

merged 3 commits into from May 11, 2019

Conversation

dima-takoy-zz
Copy link

This PR is a part of changesets described here #213 (comment)

@dima-takoy-zz
Copy link
Author

dima-takoy-zz commented May 7, 2019

Should I create another PR where I update dependencies?

Can I update those inside this PR?

@lukastaegert
Copy link
Member

Can I update those inside this PR?

Definitely!

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should actually add something like babel-preset-env and the target version of Node 6? Then we can easily update to Node 8 in the future once the time has come and provide the best output possible while maintaining compatibility. What do you think?

@dima-takoy-zz dima-takoy-zz changed the title replace buble with babel replace buble with babel, update deps May 8, 2019
@dima-takoy-zz
Copy link
Author

After those changes, I think we can rewrite sources to async-await syntax. It will be compiled to promises by babel then we just change target version to 8 ;)

I already have a branch with refactored this package to async-await syntax. Should I send a PR?

@lukastaegert
Copy link
Member

Sounds good! I assume it will also work for the tests via babel-register?

@dima-takoy-zz
Copy link
Author

dima-takoy-zz commented May 8, 2019

Sounds good! I assume it will also work for the tests via babel-register?

I think yes. It already works with it.

current mocha opts(with this PR):

--require @babel/register

@dima-takoy-zz
Copy link
Author

SHould I add refactored to async-await version to this PR?

@lukastaegert
Copy link
Member

SHould I add refactored to async-await version to this PR?

Sure, sounds good, considering you already seem to have done the work. Just avoid utils/promisify for the Node 6 compatibility.

@dima-takoy-zz
Copy link
Author

I prefer to merge this PR as is. Then I add PR with refactored to async-await syntax.

@lukastaegert lukastaegert merged commit 3e2523f into rollup:master May 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants