Skip to content
This repository was archived by the owner on Aug 4, 2021. It is now read-only.

Fix TypeScript Typings (rename and export Options interface) #206

Merged
merged 4 commits into from
Apr 10, 2019

Conversation

Kocal
Copy link
Contributor

@Kocal Kocal commented Apr 9, 2019

Hi, this PR is like a small following of #189.

Before #189 was created, we add to install package @types/rollup-plugin-node-resolve (source) to make this plugin usable in a TypeScript environment.

The typings exported an interface Options, so I did the same here to minimize code updates for people that use import { Options } from 'rollup-plugin-node-resolve'.

Thanks :)

Kocal added 3 commits April 9, 2019 21:55

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.
@Kocal Kocal changed the title Fix TypeScript Typings Fix TypeScript Typings (rename and export Options interface) Apr 9, 2019
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@lukastaegert lukastaegert merged commit f582f9c into rollup:master Apr 10, 2019
@Kocal Kocal deleted the type/export-options-interface branch April 10, 2019 05:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants