Skip to content
This repository has been archived by the owner on Aug 4, 2021. It is now read-only.

Resolve errors are swallowed #167

Closed
chinesedfan opened this issue Jul 13, 2018 · 2 comments
Closed

Resolve errors are swallowed #167

chinesedfan opened this issue Jul 13, 2018 · 2 comments

Comments

@chinesedfan
Copy link

https://github.com/rollup/rollup-plugin-node-resolve/blob/master/src/index.js#L162

Shall err be handled first? For example, if I require('non-existed-pkg'), this plugin just throws nothing.

@dima-takoy-zz
Copy link

I tried it.

Console output:

$ rollup -c

src/index.js → dist/bundle.js...
(!) Unresolved dependencies
https://rollupjs.org/guide/en#warning-treating-module-as-external-dependency
nonexistentmodule (imported by src/index.js)
created dist/bundle.js in 97ms
Done in 0.60s.

I think is OK behavior. Modules compiled with rollup can use external dependencies that can be called in runtime later.

Can be closed now. Repen if need.

@TrySound TrySound closed this as completed May 5, 2019
@chinesedfan
Copy link
Author

Seems fixed by #183 and released in v4.0.1. Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants