Skip to content
This repository has been archived by the owner on Aug 4, 2021. It is now read-only.

Fix rollup peer dependency #240

Merged
merged 1 commit into from Aug 28, 2018
Merged

Fix rollup peer dependency #240

merged 1 commit into from Aug 28, 2018

Conversation

ylemkimon
Copy link
Contributor

@ylemkimon ylemkimon commented Aug 28, 2018

Semver range ^0.60.0 doesn't include 0.65.0, etc., as if major version is 0, minor version updates indicate breaking changes. <1 is added to be future-proof.

Semver range `^0.60.0` doesn't include `0.65.0`, etc., as if major version is 0, minor version updates indicate breaking changes. `>1` is added for future-proof.
@Andarist
Copy link
Member

Thanks! Also thanks for including <1 - I also before it's better not to assume anything before v1 release.

@nickmccurdy
Copy link

nickmccurdy commented Aug 28, 2018

Oddly enough, semver seems to allow 0.60.0 in ^0.60.0, but I keep getting peer dependency warnings in npm if I install a range newer than ^0.60.0.

const semver = require('semver')
semver.satisfies('0.60.0', '^0.60.0') // true

@Andarist Andarist merged commit 11cf7e3 into rollup:master Aug 28, 2018
@Andarist
Copy link
Member

I've released this patch, please let me know if the issue is resolved for you.

@nickmccurdy
Copy link

Thanks, 4.0.2 fixes my peer dependency on the latest Rollup.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants