Skip to content
This repository has been archived by the owner on Aug 4, 2021. It is now read-only.

Do not warn about externals when using transform runtime. #105

Closed
swernerx opened this issue Nov 22, 2016 · 2 comments · Fixed by #107
Closed

Do not warn about externals when using transform runtime. #105

swernerx opened this issue Nov 22, 2016 · 2 comments · Fixed by #107

Comments

@swernerx
Copy link
Contributor

For bundling our library we are using "transform-runtime" together with polyfill: false flag. Even if setting runtimeHelpers: true as suggested in the documentation we are seeing this confusing message:

The '${helper}' Babel helper is used more than once in your code. 

which should probably not happen in my opinion. Looking through the code it seems changing this in https://github.com/rollup/rollup-plugin-babel/blob/master/src/index.js#L64 should be enough:

} else {

into

} else (helpers !== RUNTIME) {
@swernerx
Copy link
Contributor Author

BTW: We have one bundle were we do not transpile es2015 classes (for modern clients/nodejs). In this case the whole detection in preflightCheck.js might be broken as it explicitely check for usage of the class helper to detect the runtime usage.

Rich-Harris added a commit that referenced this issue Dec 13, 2016
fix duplicated helper warnings with runtime helpers
@Rich-Harris
Copy link
Contributor

Fixed in 2.7.1 – thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants