Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(commonjs,dynamic-import-vars,inject,replace,strip): update magic-string #1373

Merged
merged 1 commit into from Dec 17, 2022

Conversation

sapphi-red
Copy link
Contributor

@sapphi-red sapphi-red commented Dec 11, 2022

Rollup Plugin Name: commonjs,dynamic-import-vars,inject,replace,strip

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers: fixes #1365

Description

sourcemap-codec@1.4.8 was deprecated and installing these plugins shows the following warning.

npm WARN deprecated sourcemap-codec@1.4.8: Please use @jridgewell/sourcemap-codec instead

This PR updates magic-string to ^0.27.0 to remove that warning.

magic-string@0.27.0 does not include any breaking changes.
https://github.com/Rich-Harris/magic-string/blob/master/CHANGELOG.md

@ice1000
Copy link

ice1000 commented Dec 14, 2022

🎉

@shellscape
Copy link
Collaborator

thanks!

@shellscape shellscape merged commit f5aa3c3 into rollup:master Dec 17, 2022
@ice1000
Copy link

ice1000 commented Dec 17, 2022

Νοιce!!

@sapphi-red sapphi-red deleted the fix/update-magic-string branch December 22, 2022 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update deprecated magic-string
4 participants