docs(commonjs): Fix declaration tag @default for ignoreTryCatch + fix some typos #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
shellscape
reviewed
Dec 7, 2022
| @@ -109,17 +109,17 @@ interface RollupCommonJSOptions { | |||
| * they should be left unconverted as it requires an optional dependency | |||
| * that may or may not be installed beside the rolled up package. | |||
| * Due to the conversion of `require` to a static `import` - the call is | |||
| * hoisted to the top of the file, outside of the `try-catch` clause. | |||
| * hoisted to the top of the file, outside the `try-catch` clause. | |||
There was a problem hiding this comment.
not really a typo but, sure
There was a problem hiding this comment.
This is picked up by Webstorm's LanguageTool and as such was underlined as a typo
shellscape
approved these changes
Dec 7, 2022
ClementValot
changed the title
|
Fixed the PR title |
ClementValot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
commonjsThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
Description