Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(plugin-virtual) Missing typescript definitions #894

Closed
impy88 opened this issue Jun 2, 2021 · 4 comments
Closed

(plugin-virtual) Missing typescript definitions #894

impy88 opened this issue Jun 2, 2021 · 4 comments

Comments

@impy88
Copy link

impy88 commented Jun 2, 2021

(plugin-virtual) Missing typescript definitions

  • Rollup Plugin Name: @rollup/plugin-virtual
  • Rollup Plugin Version: 2.0.3
  • Rollup Version: 2.50.5
  • Operating System (or Browser): MacOS
  • Node Version: 14.15.4
  • Link to reproduction (⚠️ read below):

Expected Behavior

@rollup/plugin-virtual supports typescript and has typings

Actual Behavior

The latest version (2.0.3) has no typings

Could not find a declaration file for module '@rollup/plugin-virtual'. './node_modules/@rollup/plugin-virtual/dist/index.js' implicitly has an 'any' type.

Additional Information

Hi, Please release a new version of @rollup/plugin-virtual with typescript support as I see migration to typescript was merged 9 months ago but never released.

2.0.3 https://github.com/rollup/plugins/tree/virtual-v2.0.3/packages/virtual
master https://github.com/rollup/plugins/tree/master/packages/virtual

Cheers,

@shellscape
Copy link
Collaborator

Fixed by #898

@nickrum
Copy link

nickrum commented Aug 2, 2021

Hi @shellscape, it seems like the latest version of @rollup/plugin-virtual is still 2.0.3 which does not include any typings. #898 did not affect the virtual plugin as the package has already been moved to typescript in #578.

@fjc0k
Copy link

fjc0k commented Sep 13, 2021

+1 @shellscape

image

@Finesse
Copy link

Finesse commented Nov 5, 2021

There are types for this plugin at DefinitelyTyped, but they are outdated (require Rollup version 1).

P.S. +1 for the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants