Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(html): fix <br> tag #89

Merged
merged 1 commit into from Dec 11, 2019
Merged

Conversation

newbornfrontender
Copy link
Contributor

@newbornfrontender newbornfrontender commented Dec 11, 2019

Rollup Plugin Name: html

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

maintainer edit Fixes a <br> tag in the html plugin README

@shellscape
Copy link
Collaborator

shellscape commented Dec 11, 2019

@newbornfrontender thanks for your PR.

in the future please make sure you choose the correct PR type (this one is a documentation PR since it updates a README), please make sure you fill out the Description section (where we ask people to be verbose about their PR), and please make sure you tick the other appropriate boxes. I've taken the liberty of updating your PR accordingly, to reflect how it should have been filled out.

We ask everyone to follow the issue template and fill it out in its entirety, even maintainers. This helps save maintainers precious time, and saves you time since it removes the need for follow-up discussion. Please do note that if the next PR doesn't follow the template, we will likely choose not to merge it.

@shellscape shellscape changed the title fix(html): change tag name docs(html): fix <br> tag Dec 11, 2019
@shellscape shellscape merged commit 0297e2a into rollup:master Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants