feat(legacy): normalize exports paths #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patak-dev
changed the title
shellscape
approved these changes
Jan 29, 2021
|
|
|
Thanks a lot @shellscape! Only one issue away (waiting for PR in Vite's side) and every official rollup plugin will be compatible with Vite 🎉 |
|
That's great news! |
This was referenced Mar 5, 2021
Closed
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
legacyThis PR contains:
Are tests included?
Breaking Changes?
Description
Vite 2 implements a universal rollup plugin API (for the ESM based dev server, and the build using rollup). Plugins are mostly compatible. I am maintaining a compatibility list for official rollup plugins here.
One difference in the dev server is that Vite normalizes paths to use posix slashes (in the same way as normalizePath in @rollup/pluginutils) while resolving ids. This is not an issue generally because utils like createFilter also normalize ids while matching.
This PR uses rolluputils.normalizePath to normalizes ids in the exports map for @rollup/plugin-legacy so it is compatible with Vite. This will fix vitejs/vite#1521